envparse icon indicating copy to clipboard operation
envparse copied to clipboard

Improves Warning messaging

Open ghost opened this issue 8 years ago • 4 comments

Improves on the original warning.warn message (for when an envfile wasn't found) by including the search path used for a given file.

ghost avatar Apr 18 '16 22:04 ghost

Looks useful.

Think an additional function for this is probably overkill, just adding a list of paths we've traversed to read_envfile should be good enough.

rconradharris avatar Apr 18 '16 23:04 rconradharris

Thanks for saying that it looks useful and for quickly responding to the PR (👍 ).

I think the last commit is what you had in mind, but let me know if I misunderstood and I can modify it.

ghost avatar Apr 19 '16 17:04 ghost

It is worth noting that the change to only use a list in that fashion means that the UserWarning will contain all failed path lookups (i.e. read_envfile('a'); read_envfile('b') will show warnings on 'b' that contain paths from 'a'). Let me know if you want me to write in the "only show warnings for filename" behavior.

ghost avatar Apr 19 '16 19:04 ghost

@rconradharris are you still maintaining this repo? The last commit is 7 years ago. Thanks

MichaelCurrie avatar Jun 11 '22 16:06 MichaelCurrie