Hive-JSON-Serde icon indicating copy to clipboard operation
Hive-JSON-Serde copied to clipboard

Fixed #issue-70 related to get_json_object functionality for hive-serde

Open snehalNagmote opened this issue 10 years ago • 5 comments

This issue is related to get_json_object does not work with hive serde on Json String unless one defines it as struct. https://github.com/rcongiu/Hive-JSON-Serde/issues/70

snehalNagmote avatar May 28 '14 18:05 snehalNagmote

I fixed this by adding String object inspector that would handle Json and tested it , it works, Look forward to your review and comments .

snehalNagmote avatar May 28 '14 18:05 snehalNagmote

I have recently reported a similar issue with get_json_object,

https://github.com/rcongiu/Hive-JSON-Serde/issues/82

then I merged with develop branch with pull request and its working perfectly. Is this eventually going to merge with developing branch ?

ashokkumar-dhanavel avatar Sep 11 '14 05:09 ashokkumar-dhanavel

This pull request is mostly formatting changes and can't be merged automatically. When a pull request is like that, it's much harder to review. Please do keep in mind I work on this on my spare time. Can you please submit a pull request or a diff for just the relevant change ?

rcongiu avatar Sep 11 '14 06:09 rcongiu

Apologies for inconvenience . My IDE messed up with formatting , but I did revert back those formatting changes after I created pull request . If you look into files changed , you should be able to figure out the relevant changes/diff , Or I would submit new pull request by tomorrow

Let me know ,

Thanks, Snehal

On 10 September 2014 23:29, Roberto Congiu [email protected] wrote:

This pull request is mostly formatting changes and can't be merged automatically. When a pull request is like that, it's much harder to review. Please do keep in mind I work on this on my spare time. Can you please submit a pull request or a diff for just the relevant change ?

— Reply to this email directly or view it on GitHub https://github.com/rcongiu/Hive-JSON-Serde/pull/71#issuecomment-55225250 .

snehalNagmote avatar Sep 11 '14 07:09 snehalNagmote

This should be closed via https://github.com/rcongiu/Hive-JSON-Serde/pull/90.

dblock avatar Apr 02 '17 18:04 dblock