rclone icon indicating copy to clipboard operation
rclone copied to clipboard

Add vendor OpenCloud

Open dragotin opened this issue 6 months ago • 9 comments

What is the purpose of this change?

It adds a new WebDAV vendor OpenCloud to the webdav backend of rclone.

OpenCloud is a fork of ownCloud InfiniteScale which is actively maintained by some former InfiniteScale developers. It's living on Github under https://github.com/opencloud-eu

Was the change discussed in an issue or in the forum before?

Not that I know

Checklist

  • [x] I have read the contribution guidelines.
  • [x] I have added tests for all changes in this PR if appropriate.
  • [x] I have added documentation for the changes if appropriate.
  • [x] All commit messages are in house style.
  • [x] I'm done, this Pull Request is ready for review :-)

This PR still does not fix the problems as discussed in https://github.com/rclone/rclone/pull/8172#issuecomment-3015157471 but still suffers from the same problem.

dragotin avatar Jun 30 '25 15:06 dragotin

FYI @dragonchaser @rhafer

dragotin avatar Jun 30 '25 16:06 dragotin

Yes, I will provide the test server setup as soon as the InfiniteScale tests are running and I can test it properly.

dragotin avatar Jul 02 '25 14:07 dragotin

Ping me when you want me to do a review :-)

ncw avatar Jul 21 '25 16:07 ncw

@ncw now it's all green - would be great if you could re-consider merging this - thanks!

dragotin avatar Sep 10 '25 08:09 dragotin

@ncw I am really looking forward to this. OpenCloud has gained a lot of momentum in the community.

micbar avatar Sep 10 '25 08:09 micbar

Any progress on this PR?

Neustradamus avatar Nov 10 '25 03:11 Neustradamus

Additional suggestion: disable intergrationtests when running with make racequicktest Becaus this might fail and run against a locally installed version because of https://github.com/rclone/rclone/blob/80e6389a50d6492c01d225d699e45dcec5d11c00/cmd/gitannex/e2e_test.go#L164 (or use fixed paths for placing the binaries)

diff --git a/Makefile b/Makefile
index 5e75a4499..08c165901 100644
--- a/Makefile
+++ b/Makefile
@@ -91,7 +91,7 @@ quicktest:
        RCLONE_CONFIG="/notfound" go test $(LDFLAGS) $(BUILDTAGS) ./...
 
 racequicktest:
-       RCLONE_CONFIG="/notfound" go test $(LDFLAGS) $(BUILDTAGS) -cpu=2 -race ./...
+       IS_RACE_QUICK_TEST=true RCLONE_CONFIG="/notfound" go test $(LDFLAGS) $(BUILDTAGS) -cpu=2 -race ./...
 
 compiletest:
        RCLONE_CONFIG="/notfound" go test $(LDFLAGS) $(BUILDTAGS) -run XXX ./...
diff --git a/cmd/gitannex/e2e_test.go b/cmd/gitannex/e2e_test.go
index ffc630100..df6b78d65 100644
--- a/cmd/gitannex/e2e_test.go
+++ b/cmd/gitannex/e2e_test.go
@@ -183,7 +183,9 @@ func skipE2eTestIfNecessary(t *testing.T) {
        if testing.Short() {
                t.Skip("Skipping due to short mode.")
        }
-
+       if os.Getenv("IS_RACE_QUICK_TEST") == "true" {
+               t.Skip("Skipping due to race quick test.")
+       }
        // TODO(#7984): Port e2e tests to `fstest` framework.
        if *fstest.RemoteName != "" {
                t.Skip("Skipping because fstest remote was specified.")

dragonchaser avatar Nov 17 '25 14:11 dragonchaser

@ncw any chance to merge? The CI is green now :-)

dragotin avatar Nov 17 '25 14:11 dragotin

ping @ncw - anything missing?

dragotin avatar Nov 27 '25 15:11 dragotin