rclone icon indicating copy to clipboard operation
rclone copied to clipboard

segmentation fault in `copy`/`sync` with `protondrive`

Open thomaseizinger opened this issue 1 year ago • 10 comments

The associated forum post URL from https://forum.rclone.org

I didn't post to the forum as I'd assume that a segmentation fault bug should be tracked here instead.

What is the problem you are having with rclone?

It crashed with a segmentation fault.

What is your rclone version (output from rclone version)

rclone 1.64.2
- os/version: nixos 24.05 (Uakari) (64 bit)
- os/kernel: 6.5.13 (x86_64)
- os/type: linux
- os/arch: amd64
- go/version: go1.21.4
- go/linking: dynamic
- go/tags: cmount

Which OS you are using and how many bits (e.g. Windows 7, 64 bit)

NixOS 23.11, Kernel 6.5.13

Which cloud storage system are you using? (e.g. Google Drive)

ProtonDrive

The command you were trying to run (e.g. rclone copy /tmp remote:tmp)

rclone bisync

A log from the command with the -vv flag (e.g. output from rclone -vv copy /tmp remote:tmp)

The command was running in the background and I put it to sleep at some point which I assume is the reason the network connectivity got lost. When I resumed, I saw the following in the terminal:

2024/01/14 09:17:17.886781 ERROR RESTY Post "https://mail.proton.me/api/drive/blocks": read tcp 192.168.181.51:33600->185.70.42.37:443: read: connection timed out, Attempt 1
2024/01/14 09:17:17.886784 ERROR RESTY Post "https://mail.proton.me/api/drive/shares/ebQS8h4MqtD4ky40Y4p7t7oUgBmNqRXGRsQ79jvhRbOX0mfAKRpwr-vOCqGVux-l-Det0w_9ZEtt7_G-f2iZtw==/files": read tcp 192.168.181.51:33600->185.70.42.37:443: read: connection timed out, Attempt 1
2024/01/14 09:17:18.772413 ERROR RESTY Post "https://mail.proton.me/api/drive/shares/ebQS8h4MqtD4ky40Y4p7t7oUgBmNqRXGRsQ79jvhRbOX0mfAKRpwr-vOCqGVux-l-Det0w_9ZEtt7_G-f2iZtw==/files": read tcp 172.19.1.159:46702->185.70.42.37:443: read: connection reset by peer, Attempt 2
2024/01/14 09:17:18.772413 ERROR RESTY Post "https://mail.proton.me/api/drive/blocks": read tcp 172.19.1.159:46710->185.70.42.37:443: read: connection reset by peer, Attempt 2
2024/01/14 09:17:19.676913 ERROR RESTY Post "https://mail.proton.me/api/drive/blocks": read tcp 172.19.1.159:46730->185.70.42.37:443: read: connection reset by peer, Attempt 3
2024/01/14 09:17:19.697041 ERROR RESTY Post "https://mail.proton.me/api/drive/shares/ebQS8h4MqtD4ky40Y4p7t7oUgBmNqRXGRsQ79jvhRbOX0mfAKRpwr-vOCqGVux-l-Det0w_9ZEtt7_G-f2iZtw==/files": read tcp 172.19.1.159:46736->185.70.42.37:443: read: connection reset by peer, Attempt 3
2024/01/14 09:17:20.819583 ERROR RESTY Post "https://mail.proton.me/api/drive/shares/ebQS8h4MqtD4ky40Y4p7t7oUgBmNqRXGRsQ79jvhRbOX0mfAKRpwr-vOCqGVux-l-Det0w_9ZEtt7_G-f2iZtw==/files": read tcp 172.19.1.159:44808->185.70.42.37:443: read: connection reset by peer, Attempt 4
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x22d4909]

goroutine 993 [running]:
github.com/go-resty/resty/v2.(*Response).StatusCode(...)
	github.com/go-resty/resty/[email protected]/response.go:52
github.com/henrybear327/go-proton-api.(*Client).CreateFile(0x80?, {0x367e798, 0xc0004374a0}, {0xc00120a000, 0x58}, {{0xc006c53440, 0x58}, {0xc000d7f680, 0x221}, {0xc00877ee40, ...}, ...})
	github.com/henrybear327/[email protected]/link.go:51 +0xc9
github.com/henrybear327/Proton-API-Bridge.(*ProtonDrive).createFileUploadDraft.func1()
	github.com/henrybear327/[email protected]/file_upload.go:156 +0xda
github.com/henrybear327/Proton-API-Bridge.(*ProtonDrive).createFileUploadDraft(0xc0007ae980, {0x367e798, 0xc0004374a0}, 0xc00dfdf260, {0xc000d266be, 0x22}, {0x40?, 0x0?, 0x1?}, {0x306261e, ...})
	github.com/henrybear327/[email protected]/file_upload.go:191 +0x42b
github.com/henrybear327/Proton-API-Bridge.(*ProtonDrive).uploadFile(0xc00120b920?, {0x367e798, 0xc0004374a0}, 0xc000f038f0?, {0xc000d266be, 0x22}, {0xc000f03888?, 0x11bab96?, 0x49c6e20?}, {0x365d980, ...}, ...)
	github.com/henrybear327/[email protected]/file_upload.go:435 +0x11f
github.com/henrybear327/Proton-API-Bridge.(*ProtonDrive).UploadFileByReader(0xc000f038e8?, {0x367e798, 0xc0004374a0}, {0xc00120b920?, 0x1115846?}, {0xc000d266be, 0x22}, {0x0, 0xed2b437db, 0x49c6e20}, ...)
	github.com/henrybear327/[email protected]/file_upload.go:479 +0xd3
github.com/rclone/rclone/backend/protondrive.(*Object).Update.func1()
	github.com/rclone/rclone/backend/protondrive/protondrive.go:950 +0xa5
github.com/rclone/rclone/fs.pacerInvoker(0xc000b4e600?, 0xc00078ab00?, 0x80?)
	github.com/rclone/rclone/fs/pacer.go:88 +0x2c
github.com/rclone/rclone/lib/pacer.(*Pacer).call(0xc000b4e600, 0xc000f03a50?, 0xa)
	github.com/rclone/rclone/lib/pacer/pacer.go:197 +0x7c
github.com/rclone/rclone/lib/pacer.(*Pacer).Call(0xc000b4e600, 0x367e798?)
	github.com/rclone/rclone/lib/pacer/pacer.go:216 +0x92
github.com/rclone/rclone/backend/protondrive.(*Object).Update(0xc002469040, {0x367e798?, 0xc0004374a0}, {0x365d980?, 0xc00643a000}, {0x7fc66c5c4fc0, 0xc000d17e60}, {0xc0008ac300, 0x1, 0x1})
	github.com/rclone/rclone/backend/protondrive/protondrive.go:949 +0x32c
github.com/rclone/rclone/backend/protondrive.(*Fs).Put(0x366de10?, {0x367e798, 0xc0004374a0}, {0x365d980, 0xc00643a000}, {0x7fc66c5c4fc0?, 0xc000d17e60?}, {0xc0008ac300, 0x1, 0x1})
	github.com/rclone/rclone/backend/protondrive/protondrive.go:696 +0x205
github.com/rclone/rclone/fs/operations.Copy({0x367e798, 0xc0004374a0}, {0x3692278, 0xc000b584d0}, {0x0?, 0x0?}, {0xc000d26690, 0x50}, {0x36918d8, 0xc000d17e60})
	github.com/rclone/rclone/fs/operations/operations.go:478 +0x24f0
github.com/rclone/rclone/fs/sync.(*syncCopyMove).pairCopyOrMove(0xc000ad86c0, {0x367e798, 0xc0004374a0}, 0x0?, {0x3692278, 0xc000b584d0}, 0x0?, 0xc00118f738?)
	github.com/rclone/rclone/fs/sync/sync.go:446 +0x1f6
created by github.com/rclone/rclone/fs/sync.(*syncCopyMove).startTransfers in goroutine 1
	github.com/rclone/rclone/fs/sync/sync.go:473 +0x45

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

thomaseizinger avatar Jan 13 '24 23:01 thomaseizinger

Hi there! Thanks for reporting this.

rclone 1.64.2

This is a couple of versions behind, and there have been some recent updates to ProtonDrive (and its dependencies). Could you retry this with v1.65.1 and report back if the problem persists?

If it does, it would also be helpful to know whether it occurs in rclone sync (i.e. whether the issue is specific to bisync or protondrive more generally.)

nielash avatar Jan 14 '24 01:01 nielash

This is a couple of versions behind, and there have been some recent updates to ProtonDrive (and its dependencies). Could you retry this with v1.65.1 and report back if the problem persists?

I am unsure if I can reproduce it but I'll update and try again :)

thomaseizinger avatar Jan 15 '24 00:01 thomaseizinger

Same here

rclone version:

rclone v1.67.0-beta.7822.9c9487365
- os/version: debian bookworm/sid (64 bit)
- os/kernel: 6.8.0-76060800daily20240311-generic (x86_64)
- os/type: linux
- os/arch: amd64
- go/version: go1.22.1
- go/linking: static
- go/tags: none

copy command: rclone sync proton: ~/protonDrive

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xb9a379]

goroutine 119 [running]:
github.com/rclone/rclone/fs/operations.(*copy).verify(0xc00136ef30, {0x2b12010, 0xc000e0ecd0}, {0x2b27b00, 0xc00125f320})
	github.com/rclone/rclone/fs/operations/copy.go:276 +0x2d9
github.com/rclone/rclone/fs/operations.(*copy).copy(0xc00136ef30, {0x2b12010, 0xc000e0ecd0})
	github.com/rclone/rclone/fs/operations/copy.go:335 +0x619
github.com/rclone/rclone/fs/operations.Copy({0x2b12010, 0xc000e0ecd0}, {0x2b27a90, 0xc000e0c0a0}, {0x0, 0x0}, {0xc000af5fc8, 0x17}, {0x2b28510, 0xc0009f7d60})
	github.com/rclone/rclone/fs/operations/copy.go:404 +0x485
github.com/rclone/rclone/fs/sync.(*syncCopyMove).pairCopyOrMove(0xc0005f8c88, {0x2b12010, 0xc000e0ecd0}, 0xc000e0eb40, {0x2b27a90, 0xc000e0c0a0}, 0x19, 0xc000505fb0?)
	github.com/rclone/rclone/fs/sync/sync.go:498 +0x205
created by github.com/rclone/rclone/fs/sync.(*syncCopyMove).startTransfers in goroutine 1
	github.com/rclone/rclone/fs/sync/sync.go:528 +0x6b

leowinterde avatar Mar 30 '24 22:03 leowinterde

@LeoWinterDE thanks, that's very helpful! I see part of the problem now. Are you able to test it again with this fix?: https://github.com/nielash/rclone/commit/fe1526317d6b9af303de1d1cab83fb173e454bce

This should at least fix the panic, but more investigation is probably warranted to determine why protondrive is ending up in that code path in the first place -- it indicates that an object was corrupted on transfer, which shouldn't normally happen. It would be helpful to see a debug log to investigate that further.

As this issue is not specific to bisync, I will also edit the title accordingly.

nielash avatar Mar 31 '24 05:03 nielash

@nielash I cherry-picked your commit as e053c8a1c03e9c4396e3588bbfc432ed4ff79814 as it looked correct to me which means it will be in the latest beta in 15-30 minutes and released in v1.67 and v1.66.1

@leowinterde can you try the beta v1.67.0-beta.7840.e053c8a1c on branch master (uploaded in 15-30 mins) to see if it segfaults? Hopefully it won't and you can show the log it makes.

ncw avatar Apr 02 '24 14:04 ncw

@nielash @ncw the v1.67.0-beta.7840.e053c8a1c linux build failed so i tested with my own build. With https://github.com/nielash/rclone/commit/fe1526317d6b9af303de1d1cab83fb173e454bce the sync run without any problems for me.

Build:

leo@leo-pc:~$ git clone https://github.com/nielash/rclone
Cloning into 'rclone'...
remote: Enumerating objects: 117539, done.
remote: Counting objects: 100% (3475/3475), done.
remote: Compressing objects: 100% (540/540), done.
remote: Total 117539 (delta 3047), reused 3000 (delta 2931), pack-reused 114064
Receiving objects: 100% (117539/117539), 184.11 MiB | 25.00 MiB/s, done.
Resolving deltas: 100% (73328/73328), done.
leo@leo-pc:~$ cd rclone/
leo@leo-pc:~/rclone$ git reset --hard fe1526317d6b9af303de1d1cab83fb173e454bce
HEAD is now at fe1526317 copy: fix nil pointer dereference when corrupted on transfer with nil dst
leo@leo-pc:~/rclone$ go build -v --ldflags "-s -X github.com/rclone/rclone/fs.Version=v1.67.0-beta.TESTING"
go: downloading github.com/golang-jwt/jwt/v4 v4.5.0
go: downloading github.com/buengese/sgzip v0.1.1
go: downloading golang.org/x/oauth2 v0.16.0
go: downloading github.com/youmark/pkcs8 v0.0.0-20201027041543-1326539a0a0a
go: downloading golang.org/x/sync v0.6.0
go: downloading github.com/gabriel-vasile/mimetype v1.4.3
go: downloading github.com/patrickmn/go-cache v2.1.0+incompatible
go: downloading go.etcd.io/bbolt v1.3.8
go: downloading golang.org/x/net v0.20.0
go: downloading golang.org/x/time v0.5.0
go: downloading github.com/spf13/cobra v1.8.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading golang.org/x/text v0.14.0
go: downloading github.com/Max-Sum/base32768 v0.0.0-20230304063302-18e6ce5945fd
go: downloading github.com/rfjakob/eme v1.1.2
go: downloading golang.org/x/crypto v0.18.0
go: downloading github.com/Azure/azure-sdk-for-go/sdk/azcore v1.9.1
go: downloading github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.4.0
go: downloading github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.2.1
go: downloading google.golang.org/api v0.156.0
go: downloading github.com/Azure/azure-sdk-for-go/sdk/storage/azfile v1.1.1
go: downloading github.com/koofr/go-httpclient v0.0.0-20230225102643-5d51a2e9dea6
go: downloading github.com/koofr/go-koofrclient v0.0.0-20221207135200-cbd7fc9ad6a6
go: downloading github.com/jlaffaye/ftp v0.2.0
go: downloading github.com/colinmarc/hdfs/v2 v2.4.0
go: downloading github.com/jcmturner/gokrb5/v8 v8.4.4
go: downloading github.com/ncw/swift/v2 v2.0.2
go: downloading github.com/dropbox/dropbox-sdk-go-unofficial/v6 v6.0.5
go: downloading github.com/t3rm1n4l/go-mega v0.0.0-20240219080617-d494b6a8ace7
go: downloading github.com/yunify/qingstor-sdk-go/v3 v3.2.0
go: downloading github.com/henrybear327/Proton-API-Bridge v1.0.0
go: downloading github.com/henrybear327/go-proton-api v1.0.0
go: downloading github.com/putdotio/go-putio/putio v0.0.0-20200123120452-16d982cac2b8
go: downloading golang.org/x/exp v0.0.0-20240112132812-db7319d0e0e3
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/oracle/oci-go-sdk/v65 v65.55.1
go: downloading github.com/aws/aws-sdk-go v1.49.20
go: downloading github.com/coreos/go-semver v0.3.1
go: downloading github.com/Azure/go-ntlmssp v0.0.0-20221128193559-754e69321358
go: downloading github.com/cloudsoda/go-smb2 v0.0.0-20231124195312-f3ec8ae2c891
go: downloading github.com/pkg/sftp v1.13.6
go: downloading github.com/xanzy/ssh-agent v0.3.3
go: downloading github.com/google/uuid v1.5.0
go: downloading storj.io/uplink v1.12.2
go: downloading github.com/pkg/xattr v0.4.9
go: downloading golang.org/x/sys v0.16.0
go: downloading github.com/hanwen/go-fuse/v2 v2.4.0
go: downloading github.com/atotto/clipboard v0.1.4
go: downloading github.com/gdamore/tcell/v2 v2.7.0
go: downloading github.com/mattn/go-runewidth v0.0.15
go: downloading github.com/rivo/uniseg v0.4.4
go: downloading bazil.org/fuse v0.0.0-20230120002735-62a210ff1fd5
go: downloading github.com/a8m/tree v0.0.0-20240104212747-2c8764a5f17e
go: downloading github.com/ProtonMail/go-crypto v0.0.0-20230923063757-afb1ddc0824c
go: downloading github.com/jzelinskie/whirlpool v0.0.0-20201016144138-0675e54bb004
go: downloading github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/prometheus/client_golang v1.18.0
go: downloading github.com/coreos/go-systemd/v22 v22.5.0
go: downloading github.com/sirupsen/logrus v1.9.3
go: downloading github.com/Unknwon/goconfig v1.0.0
go: downloading github.com/go-chi/chi/v5 v5.0.11
go: downloading github.com/shirou/gopsutil/v3 v3.23.12
go: downloading github.com/aalpar/deheap v0.0.0-20210914013432-0cc84d79dec3
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading golang.org/x/term v0.16.0
go: downloading github.com/klauspost/compress v1.17.4
go: downloading cloud.google.com/go/compute/metadata v0.2.3
go: downloading github.com/Azure/azure-sdk-for-go/sdk/internal v1.5.1
go: downloading github.com/AzureAD/microsoft-authentication-library-for-go v1.2.1
go: downloading github.com/jcmturner/dnsutils/v2 v2.0.0
go: downloading github.com/jcmturner/gofork v1.7.6
go: downloading cloud.google.com/go/compute v1.23.3
go: downloading github.com/hashicorp/go-uuid v1.0.3
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading gopkg.in/validator.v2 v2.0.1
go: downloading google.golang.org/protobuf v1.33.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/ProtonMail/gluon v0.17.1-0.20230724134000-308be39be96e
go: downloading github.com/ProtonMail/go-srp v0.0.7
go: downloading github.com/ProtonMail/gopenpgp/v2 v2.7.4
go: downloading github.com/bradenaw/juniper v0.15.2
go: downloading github.com/PuerkitoBio/goquery v1.8.1
go: downloading github.com/emersion/go-message v0.18.0
go: downloading github.com/emersion/go-vcard v0.0.0-20230815062825-8fda7d206ec9
go: downloading github.com/go-resty/resty/v2 v2.11.0
go: downloading github.com/relvacode/iso8601 v1.3.0
go: downloading google.golang.org/grpc v1.60.1
go: downloading github.com/googleapis/gax-go/v2 v2.12.0
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.3
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/go-git/go-billy/v5 v5.5.0
go: downloading github.com/willscott/go-nfs v0.0.2
go: downloading github.com/moby/sys/mountinfo v0.7.1
go: downloading github.com/abbot/go-http-auth v0.4.0
go: downloading github.com/anacrolix/dms v1.6.0
go: downloading github.com/anacrolix/log v0.14.5
go: downloading goftp.io/server/v2 v2.0.1
go: downloading github.com/Mikubill/gofakes3 v0.0.3-0.20230622102024-284c0f988700
go: downloading github.com/kr/fs v0.1.0
go: downloading github.com/gdamore/encoding v1.0.0
go: downloading github.com/lucasb-eyer/go-colorful v1.2.0
go: downloading github.com/jtolio/eventkit v0.0.0-20231019094657-5d77ebb407d9
go: downloading github.com/spacemonkeygo/monkit/v3 v3.0.22
go: downloading github.com/zeebo/errs v1.3.0
go: downloading storj.io/common v0.0.0-20240111121419-ecae1362576c
go: downloading github.com/mattn/go-isatty v0.0.20
go: downloading github.com/gofrs/flock v0.8.1
go: downloading github.com/sony/gobreaker v0.5.0
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/prometheus/client_model v0.5.0
go: downloading github.com/prometheus/common v0.45.0
go: downloading github.com/prometheus/procfs v0.12.0
go: downloading github.com/kylelemons/godebug v1.1.0
go: downloading github.com/pengsrc/go-shared v0.2.1-0.20190131101655-1999055a4a14
go: downloading github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading github.com/andybalholm/cascadia v1.3.2
go: downloading github.com/emersion/go-textwrapper v0.0.0-20200911093747-65d896831594
go: downloading github.com/google/s2a-go v0.1.7
go: downloading go.opencensus.io v0.24.0
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.46.1
go: downloading github.com/jmespath/go-jmespath v0.4.0
go: downloading github.com/russross/blackfriday/v2 v2.1.0
go: downloading github.com/ProtonMail/go-mime v0.0.0-20230322103455-7d82a3887f2f
go: downloading github.com/rasky/go-xdr v0.0.0-20170124162913-1a41d1a06c93
go: downloading github.com/willscott/go-nfs-client v0.0.0-20240104095149-b44639837b00
go: downloading github.com/hashicorp/golang-lru/v2 v2.0.7
go: downloading github.com/anacrolix/generics v0.0.0-20230911070922-5dd7545c6b13
go: downloading github.com/gogo/protobuf v1.3.2
go: downloading github.com/ryszard/goskiplist v0.0.0-20150312221310-2dfbae5fcf46
go: downloading storj.io/drpc v0.0.33
go: downloading storj.io/picobuf v0.0.2-0.20230906122608-c4ba17033c6c
go: downloading storj.io/infectious v0.0.2
go: downloading github.com/zeebo/blake3 v0.2.3
go: downloading github.com/jtolio/noiseconn v0.0.0-20231127013910-f6d9ecbf1de7
go: downloading github.com/cloudflare/circl v1.3.7
go: downloading github.com/jcmturner/aescts/v2 v2.0.0
go: downloading github.com/jcmturner/rpc/v2 v2.0.3
go: downloading github.com/golang-jwt/jwt/v5 v5.2.0
go: downloading github.com/jcmturner/goidentity/v6 v6.0.1
go: downloading github.com/googleapis/enterprise-certificate-proxy v0.3.2
go: downloading github.com/golang/protobuf v1.5.3
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240108191215-35c7eff3a6b1
go: downloading github.com/matttproud/golang_protobuf_extensions/v2 v2.0.0
go: downloading github.com/felixge/httpsnoop v1.0.4
go: downloading go.opentelemetry.io/otel v1.21.0
go: downloading go.opentelemetry.io/otel/metric v1.21.0
go: downloading go.opentelemetry.io/otel/trace v1.21.0
go: downloading github.com/calebcase/tmpfile v1.0.3
go: downloading github.com/flynn/noise v1.0.1
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading github.com/klauspost/cpuid/v2 v2.2.6
go: downloading github.com/geoffgarside/ber v1.1.0
go: downloading github.com/go-logr/logr v1.4.1
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/cronokirby/saferith v0.33.0
go: downloading github.com/ProtonMail/bcrypt v0.0.0-20211005172633-e235017c1baf
leo@leo-pc:~/rclone$ ./rclone --version
rclone v1.67.0-beta.TESTING
- os/version: debian bookworm/sid (64 bit)
- os/kernel: 6.8.0-76060800daily20240311-generic (x86_64)
- os/type: linux
- os/arch: amd64
- go/version: go1.22.1
- go/linking: dynamic
- go/tags: none

leowinterde avatar Apr 02 '24 16:04 leowinterde

@nielash Unfortunately the test for copy verify turned out to be very unreliable on Linux/Windows so I have disabled it pending a rethink! 7c9f1b8917fd12809ccb2e18dc0ab5f3dbdc6267 I tried several approaches to make it more reliable but failed!

ncw avatar Apr 02 '24 17:04 ncw

@ncw sorry about that, and thanks for sorting that out! Didn't expect it to be merged so soon -- I surely would have caught the issue on the PR when the CI failed! 😅

@leowinterde Thanks for testing it and glad to hear it worked! Were there no corrupted on transfer errors during your sync? If not, it seems we are lacking a way to reproduce the underlying protondrive issue, and it's very hard to fix a bug that can't be reproduced.

Perhaps this issue should be closed for now, and reopened if/when it comes up again?

nielash avatar Apr 03 '24 04:04 nielash

@nielash

sorry about that, and thanks for sorting that out! Didn't expect it to be merged so soon -- I surely would have caught the issue on the PR when the CI failed! 😅

Not your fault! I should have sent the commit for a run through the CI first but I didn't - naughty!

ncw avatar Apr 03 '24 10:04 ncw

@leowinterde Thanks for testing it and glad to hear it worked! Were there no corrupted on transfer errors during your sync? If not, it seems we are lacking a way to reproduce the underlying protondrive issue, and it's very hard to fix a bug that can't be reproduced.

I did not see a corrupted on transfer error yet, but its still syncing in the background with ~1.5TB left.

leowinterde avatar Apr 03 '24 10:04 leowinterde