business-card-generator icon indicating copy to clipboard operation
business-card-generator copied to clipboard

Published 20 hours ago • verified publisher icon rclement

Adding the possibility to include the cellphone

Open zerabba opened this issue 7 months ago • 3 comments

I just added a cellphone field in the form and link this to the qr code generator.

zerabba avatar Apr 29 '25 18:04 zerabba

Thanks @zerabba for the PR, that sounds like a welcome addition!

However, it's been a while since this software has received some updates (I can see the current CI state is failing for instance). Let me bring back the project to life, then I will address your PR if that's okay with you

rclement avatar Apr 30 '25 06:04 rclement

My wife had the need to generate business cards for a company and found your app. Just the cellphone was missing and that's why I fork the repo and quickly implement it for her and run it temporarily on my vps.

I thought it would be useful for others, that's why I made this pull request.

regards

Le mer. 30 avr. 2025 à 08:35, Romain Clement @.***> a écrit :

rclement left a comment (rclement/business-card-generator#214) https://github.com/rclement/business-card-generator/pull/214#issuecomment-2840948820

Thanks @zerabba https://github.com/zerabba for the PR, that sounds like a welcome addition!

However, it's been a while since this software has received some updates (I can see the current CI state is failing for instance). Let me bring back the project to life, then I will address your PR if that's okay with you

— Reply to this email directly, view it on GitHub https://github.com/rclement/business-card-generator/pull/214#issuecomment-2840948820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIHGCX2TOIIFL3ZAIS4SMD24BVJZAVCNFSM6AAAAAB4DWWGD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBQHE2DQOBSGA . You are receiving this because you were mentioned.Message ID: @.***>

zerabba avatar Apr 30 '25 06:04 zerabba

Thanks for the explainer.

However one thing I wonder: was not the already present "phone" field sufficient? How does the cellphone field differ?

Here is a render sample: https://business-card-generator.vercel.app/card?card_type=vcard&firstname=John&lastname=Doe&nickname=&picture=&birthday=&company=&job=&email=&phone=%2B330600000000&website=&street=&city=&zipcode=&state=&country=

rclement avatar Apr 30 '25 07:04 rclement

@zerabba closing this PR in favor of #295 (rebased, cleaned-up and fixed a few things based on your original work). Thank you for your contribution!

rclement avatar Nov 06 '25 16:11 rclement