gitg0
gitg0 copied to clipboard
rchtgpt
Feat/typescript
Hi! I know I didn't open an issue in advance but wondered whether you'd have any interest in this:
- Adds typescript support
- Building implemented via
tsc
- Building implemented via
- Refactors console.logs to their own function
- Refactors some anonymous functions to arrow functions
- Turns some callback functions into
async/await.
I'm happy to continue implementing similar changes but wanted to wave this under your noses first!
@dotrachit Wanted to ensure you had interest in me continuing down this path before doing any further work, hence why some of the function() calls remain in there
@dotrachit Wanted to ensure you had interest in me continuing down this path before doing any further work, hence why some of the
function()calls remain in there
Yes, definitely. I'll do a detailed review of the PR in some time, but yes I believe these changes are quite important. @emacsified
@dotrachit That's why I raised this PR as a WIP. It depends on your definition of 'need'! Typescript can help add to the maintainability of a project, remove bugs etc. But it's really your call as to whether you want it in the repository or not.
If you feel TS is an additional cross you do not wish to bear I'm happy to open a new PR with just the refactoring and no Types
@dotrachit That's why I raised this PR as a WIP. It depends on your definition of 'need'! Typescript can help add to the maintainability of a project, remove bugs etc. But it's really your call as to whether you want it in the repository or not.
If you feel TS is an additional cross you do not wish to bear I'm happy to open a new PR with just the refactoring and no Types
@emacsified Yeah, I don't feel the need to add typescript as of now, considering that we've not received a good enough response from few developers about the project idea. I would love to see you contribute by refactoring the code style and over-used chunks of code because having a good source code is really important. Also, If you're up to discuss the potential use-case and viability of this dev-tool, please write me a mail at guptarachit2004[at]gmail[dot]com.