node-osmosis icon indicating copy to clipboard operation
node-osmosis copied to clipboard

Published 20 hours ago • verified publisher icon rchipka

Implements throttling

Open JonnyBGod opened this issue 8 years ago • 6 comments

JonnyBGod avatar Jun 23 '16 01:06 JonnyBGod

Many thanks for implementing this! :+1: I was surprised that it wasn't already implemented.

The Travis build failed with Error: Cannot find module 'limiter'. It looks like you forgot to update package.json with:

"dependencies": {
  "limiter": "1.1.0"
}

michaelhogg avatar Jun 23 '16 06:06 michaelhogg

Your right! My bad, should be fixed now.

JonnyBGod avatar Jun 23 '16 14:06 JonnyBGod

Are there plans to merge this? This is great!

sleepycat avatar Aug 25 '16 22:08 sleepycat

@sleepycat As much as I'd like to keep the dependencies down to just libxmljs and needle, I would still merge this since it's such a popular feature request.

@JonnyBGod As soon as tests are created I'll review the code and merge it in. Thanks.

rchipka avatar Aug 29 '16 04:08 rchipka

@JonnyBGod a plan for writing tests for the PR? Thank you!

lavir avatar Mar 06 '17 12:03 lavir

Merge conflict is resolved here https://github.com/samogot/node-osmosis/tree/throttling

samogot avatar May 06 '18 11:05 samogot