Rich Chiodo

Results 657 comments of Rich Chiodo

Is there an alternative? We are actually using this. https://github.com/microsoft/vscode-jupyter/blob/bf9b966c06a976c4bfdefebc0eee4012da76bf82/src/notebooks/outputs/plotSaveHandler.node.ts#L101 and here https://github.com/microsoft/vscode-jupyter/blob/bf9b966c06a976c4bfdefebc0eee4012da76bf82/src/notebooks/outputs/plotViewHandler.node.ts#L47

I think the assumption that we don't want metadata in the output could be challenged. We already put metadata in the kernel info. Adding it to the output doesn't seem...

@karrtikr just want to double check, this new API won't break existing users, right? If a user is on python insiders, but not updating the jupyter extension, they won't be...

Starts working as soon as I turn off the experiment.

I wonder if we could tag all of this code with 'Unnecessary if we could get a new API for creating controllers'? Maybe a comment in some key places?

This is explicitly hardcoded here: https://github.com/microsoft/vscode-jupyter/blob/350a17c56b64317788b269f618b24ef112806eaa/src/client/debugger/jupyter/debuggingManager.ts#L299 Likely because stepping into 3rd party code isn't going to do what you want. It will end up stepping through the display hooks for...

> I wonder if perhaps the Jupyter extension should be using the exclusion filters on a lower level to specifically exclude all those display hooks, while leaving "justMyCode" setting to...

As stated here: https://github.com/microsoft/vscode-jupyter/issues/8146#issuecomment-958443000 Just my code is not supported for stepping into cells. You have to set the environment variables like @int19h mentioned.

Additionally (maybe a separate issue), links to python files don't show up: ![image](https://user-images.githubusercontent.com/19672699/182240959-b1413c19-4df6-4f77-884f-ff5d1f5e1e62.png)