extreme_startup
extreme_startup copied to clipboard
One New Question and bundle update
Hi, thanks for the pull request. I have a few comments, as it seems to mix a few things into one PR:
- why do you need the new EventMachine version?
- can you add a spec for the previous day question?
- I'm not sure about the general knowledge question, perhaps you could just keep this for your own fork rather than pushing it into master.
On Thu, Jun 13, 2013 at 10:10 AM, Thomas Clavier [email protected]:
You can merge this Pull Request by running
git pull https://github.com/tclavier/extreme_startup master
Or view, comment on, or merge it at:
https://github.com/rchatley/extreme_startup/pull/30 Commit Summary
- New Question : what is the previous day of ...
- migrate to last eventmachine
File Changes
- M Gemfilehttps://github.com/rchatley/extreme_startup/pull/30/files#diff-0(2)
- M Gemfile.lockhttps://github.com/rchatley/extreme_startup/pull/30/files#diff-1(97)
- M lib/extreme_startup/question_factory.rbhttps://github.com/rchatley/extreme_startup/pull/30/files#diff-2(25)
Patch Links:
- https://github.com/rchatley/extreme_startup/pull/30.patch
- https://github.com/rchatley/extreme_startup/pull/30.diff