vim-ultest icon indicating copy to clipboard operation
vim-ultest copied to clipboard

Feature request: Use vim.notify

Open jesse-c opened this issue 3 years ago • 3 comments

Often I'll start a test and then do something else while I wait. It would be helpful to have a notification pop-up so that I know whether it succeeded and I can move on or it failed and I need to go back to that test.

I'd be happy to try and implement this if I could get some starting points on where to do so.

jesse-c avatar May 26 '22 12:05 jesse-c

I'm not opposed to the idea but also not sure how it would look. Would it only be for failures? If not then I'd imagine it would get quite noisy. How would it look for multiple tests running at once?

rcarriga avatar Jun 03 '22 08:06 rcarriga

I suppose it could be configurable if for passes and/or failures? Either one brings in that scenario where there's multiple tests running at once.

Since if n > 1 tests are being run, they can finish at n different times. For the current running tests, it could block on sending a notification until all current running tests are finished, and then send a combined notification? This brings up other scenarios, like if you start another test while some are already running. It could either add that to the list of running tests and still wait for the slowest?

jesse-c avatar Jun 06 '22 19:06 jesse-c

With the release of https://github.com/rcarriga/neotest, I'm going to consider this a feature request for the repo as I'll not really be contributing more to vim-ultest myself except for bug fixes. Since neotest expands on vim-ultests features and this is NeoVim only feature request I don't think there's any reason to stick to vim-ultest for users either

rcarriga avatar Jun 09 '22 21:06 rcarriga