vim-ultest icon indicating copy to clipboard operation
vim-ultest copied to clipboard

UltestSummary broken after :bdelete buffer

Open johnybx opened this issue 2 years ago • 2 comments

Describe the bug When you delete any test buffer the ultest breaks. The reason for this is that the file is kept on multiple places for example in g:ultest_buffers, s:monitored here or in tracker.py but there is no cleanup on buffer delete so when buffer is deleted all parts of ultest still want to access buffer and variables set on buffer.

I wonder if it was worth to add some autocmd to cleanup the file name from these places if buffer is deleleted.

Logs - there is nothing related

To Reproduce open any test file (or multiple), :bdelete test buffer, try to open UltestSummary and you get error:

Error detected while processing function ultest#summary#toggle[7]..ultest#summary#open[2]..<SNR>219_OpenNewWindow[36]..<SNR>219_RenderSummary[12]..<SNR>219_RenderGroup[3]..<SNR>219_RenderGroupMember:                                     
line    2:                                                                                                                                                                                                                                  
E121: Undefined variable: id                                                                                                                                                                                                                
E116: Invalid arguments for function get

Expected behavior ultest would work and ignore / cleanup closed buffer.

johnybx avatar Mar 17 '22 08:03 johnybx

Thanks for the report, should be working as expected now :smile:

rcarriga avatar Mar 19 '22 08:03 rcarriga

nice this works although I thought that we could also cleanup the cache in s:monitored and PositionTracker in the case when file is reopened :slightly_smiling_face: ( I don't do reopening closed buffer often so I am happy with current solution so this can be left as improvement )

johnybx avatar Mar 19 '22 15:03 johnybx