Riccardo Cappuzzo
Riccardo Cappuzzo
I really like the first proposal (`get_data_schema()`) I also like the second, but I am wondering if setting a default value for what then becomes X may lead to misuse...
Same here, I closed this by mistake
> The test failure on `test (macos-latest, ci-py309-min-deps)` is due to a CI infrastructure issue, not related to the code changes in this PR. > > The error shows a...
Hi @mithilP007, thanks for the PR. Could you please add a small test in `test_table_report.py` that checks that the correct message is shown when the associations are skipped? Both when...
Thanks for the comment @MarieSacksick, you're completely right. I must have lost track of this PR. @mithilP007 as Marie mentioned, the latest commit is not useful for the PR, so...
Somewhat related to #1625
The current behavior of the table report (a hidden boolean flag when the number of columns is bigger than the threshold) is something that I also find quite counterintuitive. Given...
From IRL discussion: We should proceed with solution 2. Some implementation details - Rather than `max_*_columns`, the parameters should be renamed something like "plot_distributions" "compute_associations" (not sure about these names...
> > By default, both flags are set to True, and the threshold is set in the configuration as it is now > > I think "from_config" (use the threshold)...
Noting it down here to remember: when we change the names of the parameters we need to also update the messages that are shown in the html templates like `column_associations.html`