bashhub-client icon indicating copy to clipboard operation
bashhub-client copied to clipboard

Fish support?

Open igorescobar opened this issue 9 years ago • 7 comments

Doest it support fish?

igorescobar avatar Dec 08 '15 20:12 igorescobar

Hi @igorescobar, thanks for your interest in Bashhub :D

Not yet, but should be pretty easy to add. Does fish have any precmd or preexec hooks like zsh? I built bash-preexec to add this to Bash.

Would be awesome if you put in a PR to add it. You'd basically have to create bashhub.fish in https://github.com/rcaloras/bashhub-client/tree/master/bashhub/shell. You could easily template it from bashhub.zsh Then add a new check during install to check if the shell is Fish.

rcaloras avatar Dec 08 '15 21:12 rcaloras

Looks like there's a few events that could be potentially tapped into https://github.com/fish-shell/fish-shell/pull/1563

rcaloras avatar Dec 09 '15 03:12 rcaloras

Any word?

gardinermichael avatar Mar 30 '19 05:03 gardinermichael

+1

anaibol avatar Aug 03 '20 14:08 anaibol

hey @paysonwallach, any interest in submitting a PR for this to help out the main project? Saw you had an implementation on your fork: https://github.com/paysonwallach/bashhub-client :)

rcaloras avatar Sep 08 '20 02:09 rcaloras

Sure! Great to see version 2, by the way.

paysonwallach avatar Sep 12 '20 18:09 paysonwallach

Hi! Got an error while installing.

setup (line 13): Unsupported use of '='. In fish, please use 'set bash_profile_hook '
### Bashhub.com Installation.
### This Should be at the EOF. https://bashhub.com/docs
if [ -f ~/.bashhub/bashhub.sh ]; then
    source ~/.bashhub/bashhub.sh
fi
''.
warning: Error while reading file setup

Do you mind fixing, @paysonwallach ?

weeebdev avatar Sep 09 '21 11:09 weeebdev