rc-swag

Results 115 comments of rc-swag

I don't follow when will there be a need to backspace over a `\r\n`? Internally in the `core` the context will be invalidated on a "carriage return". On the platform...

> have the .kmx files in the repo because not all environments can build them, so they should be committed. @SabineSIL This got me originally also, I was like surely...

> The user tests do not appear to test anything relating to CRLF. Is that something we can do? Correct the current test was good regression to make sure nothing...

@mcdurdin I have just been doing some logging around the contexts and finding some surprising results. 1. AITIP::ReadContext is returning the string with just `\r` and no `\n' . I...

And with that I guess this has to move back to draft

> And, this could even be buried in Core, ideally, so that the Engine doesn't need to do this legwork. We could pass `defaultLineBreakType` in as a parameter to Core......

I have implemented the normalize/ restore algorithm but not in core at this late stage as it would effect all platforms. I have created a issue #10954 to move it...

@bharanidharanj The testing of Word needs to be for an installed desktop version. It can be 365 but still needs to be an installed version. It failed the test because...

> @rc-swag I think it would be better to modify the test to suit. Thanks. @bharanidharanj I have updated the `TEST_NEWLINE_LF_ONLY` test to only have Wordpad and added another for...

> I am somewhat uncomfortable about this PR because it makes significant string handling changes very late in the beta cycle. Based on this I am going to close this...