Evan Baker

Results 227 comments of Evan Baker

@Carpe-Wang as mentioned previously, **all commits** in a PR must be signed. As long as you have commits without a (Verified) badge [on this page](https://github.com/microsoft/retina/pull/393/commits), this will not be mergeable...

https://retina.sh/docs/contributing/#office-hours-and-community-meetings

> Should we always not install cni for swift and overlay cni on WIndows nodes? The CNI binary is being installed via init-container in swift and overlay, on Linux and...

@AbelHu can you remove the block, I have reverted any change to Windows VHD for now.

@xiaozhiche320 please review the contributing guidelines, in particular [signing and signing-off](https://github.com/microsoft/retina/blob/main/CONTRIBUTING.md#cryptographic-signing-of-commits), and also update or remove the boilerplate in the description so that it is accurate.

not sure why my key is unverified, I'm signing in a codespace 😠

I believe this is intended behavior of Prometheus/Grafana - the historical data still exists for those Pods

github says these commits are from a timposter

@heyarb00 the `RETINA_AGENT_IMAGE` envvar is only used when `--debug` is also set, can you confirm you ran in debug?