usbmount
usbmount copied to clipboard
rbrito
Improvements and cleanup
This series contains a bunch of fixes and cleanups to improve overall consistency and quality. As it's quite a huge changeset (touching pretty much every single line) it is thus recommended to review it per commit (as intended).
Olliver
If your hoping to have these commits reviewed and merged within a reasonable time frame, I would suggest that you break them up into multiple pull requests as this list of commits is long enough to deter most people from taking the time to have a look.
With that being said, I have given a quick look at the first few and they seem simple enough and well formatted so I'll probably be able to do a quick review. Unfortunately, I do not have commit access so I can merge myself but at least I can lessen the load of the primary maintainer.
I will try to take a look at this pull request by this weekend... If I miss it, PLEASE,feel free to ping me...
Thanks a lot for your interest in having usbmount back from the dead.
-- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Em ter, 30 de out de 2018 17:06, mathieulj <[email protected] escreveu:
With that being said, I have given a quick look at the first few and they seem simple enough and well formatted so I'll probably be able to do a quick review. Unfortunately, I do not have commit access so I can merge myself but at least I can lessen the load of the primary maintainer.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbrito/usbmount/pull/19#issuecomment-434449996, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM8sZZfSNo7OmoDETl2RAiKaj9M7bF6ks5uqLE8gaJpZM4X42Te .
ok with that being said, do note, i have not yet tested it!! (while i do not expect much from it, this is mostly cleanup work) I will be testing it in a VM shortly (I cannot do it on my current system easily as it will interfere with a lot of stuff.
Since I am going for LABEL support and 'runtime' directory creation and removal, I will be working on that as well.
As for the separate pull requests, I thought this was quite separated :) It is all neatly organized in commits, if you read it commit by commit, it becomes very easy and sensible I hope :)
But again, i can split it up in multiple PR if that helps the load or burden!
Olliver
Hello, For the record, I started making changes in my corner on usbmount, which I discovered, after I started developing a similar project in bash... The improvements/modifications I made are available on my own fork repo, everything is functional based on the tests I was able to perform. These modifications include in particular the support of mounting via the LABEL. Unfortunately, I didn't take the time to finalize the work (merge) to send a pull request... Feel free to include in your own code the parts that may be interesting.
Those commits LGTM. Very nicely organised and explained. A real joy to review. I have yet to test it but I should be able to do so soon.
I have to admit I also still have failed to test it; so sorry for that, but hopefully soon; i just installed a KVM with debian in it and will start testing stuff; as I need it for the second series of patches I have planned :)
Is this gonna be merged in 2021 :D
Or are there any better alternatives to usbmount nowdays? :P
I have merged all outstanding pull requests to a fork of this repo due to the death in April 2021 of @rbrito. RIP.
I have no particular experience with usbmount other than using it on one of my projects, so I'm probably not a good candidate to look to for ongoing work on the project. However, it's there (presently untested) if anybody needs it.
