Robert Brennan

Results 1267 comments of Robert Brennan

Nice, yeah, agree it'd be better to have something that isn't just a bash script

Did some more investigation here. The issue is that we call _initialize() on the MonologueAgent in the first step. This adds many new documents (the initial monologue) to the chromadb...

More info: I tried removing the chromadb dependency, and using `from_documents` to initialize the memory. That seems to drop init time from ~38s to ~29s. Better, but still pretty terrible...

@foragerr yes--only Monologue uses chromadb TBH we could probably rip it out without sacrificing much quality. But we'll want a vectordb sooner rather than later...

Using BAAI/bge-small could be a serious improvement!

@openhands on windows we get a bunch of errors like this ``` _________________ test_overwrite_existing_file[LocalRuntime] __________________ self = fn = args = (,) kwargs = {} retry_state = do = def...

@openhands fix this test please ``` def test_command_output_continuation(): session = BashSession(work_dir=os.getcwd(), no_change_timeout_seconds=2) session.initialize() # Start a command that produces output slowly obs = session.execute(CmdRunAction('for i in {1..5}; do echo $i;...

@openhands the changes in this PR caused the following test to become flaky. Generate 2-3 hypotheses as to why, then fix the most likely one ``` def test_command_output_continuation(): session =...

@openhands move the logging into the GitHubService and GitLabService. Make sure the hostname/urls being used get logged too

https://github.com/OpenDevin/OpenDevin/pull/390