Robert Brennan comments

Results 1267 comments of


                                            Robert Brennan

Added playwright commands

@SmartManoj were you able to test this?

Added playwright commands

Yeah feel free to add an action that tests it!

make setup-config ignores "Enter your LLM Base URL" response

``` /bin/sh: 2: [[: not found ``` That's suspicious. Probably a syntax error in the makefile

LLM write into non exist file and maybe prompts leak

Thanks @yufansong! Can you share which model/agent? I'm trying to figure out how to set up logging so we can see the full prompt/response again--that would be super helpful. We...

LLM write into non exist file and maybe prompts leak

Looks like LLM logs are stored in `./logs/llm/$DATE/`--if you're able to look through those that'd be super helpful

test(frontend): add unit tests

This LGTM!

test(frontend): add unit tests

@amanape this seems worth getting in, and then maybe iterating on. Do you want to open it up for review?

test(frontend): add unit tests

Thanks for this! Tests are super helpful. Feel free to continue iterating in future PRs!

Small refactor of session.py

@ImSuvodeep thanks for the PRs! To make it a little easier on maintainers, in the future I'd recommend: * Giving your PR a more descriptive title * Double-checking the code...

Small refactor of session.py

Looks like there's a lint issue to fix too