Robert Brennan

Results 1267 comments of Robert Brennan

Yeah I might need to just recreate given the merge conflicts. But it was hypothetically ready for review 😄

@openhands please fix the lint errors

I have fixed the lint errors. The changes include: - Fixed trailing whitespace in multiple files - Fixed end-of-file issues in multiple files - Fixed 29 Ruff linting issues -...

IMO the way this should work is: * if scroll is already touching the bottom, auto-scroll * if the user has scrolled up at all, stop auto-scrolling I've seen this...

I dig the arrow @foragerr! My general take is that, if it's a strict improvement over what we have today, ship it. But I also don't want someone to put...

This seems good to me! Once you've got it rebased feel free to ping me

Was able to see the leakage by following `lsof -p` for this process, and clicking on files ``` ~/.cache/pypoetry/virtualenvs/openhands-ai-uYxnY0EM-py3.12/bin/python -c from multiprocessing.spawn import spawn_main; spawn_main(tracker_fd=5, pipe_handle=7) --multiprocessing-fork ``` Strange that...

OK I [fixed several leakage issues](https://github.com/All-Hands-AI/OpenHands/pull/4988/files), but this one persists 🙃 I did start calling `log_generator.close()` but no luck for posterity, you can watch the leakage with ``` while true;...