Roy Brannath comments

Results 18 comments of


                                            Roy Brannath

feat(socket): mutualize view from location and permit to link location to socket

@stonebuzz, this is working as expected.

feat(socket): mutualize view from location and permit to link location to socket

@trasher also this PR

feat(socket): mutualize view from location and permit to link location to socket

> @KongNan > > Note that we have doubts about the addition of locations in the `socket_type` list. > > A `Location` is not an `asset`. > > Best regards...

feat(socket): mutualize view from location and permit to link location to socket

> > Note that we have doubts about the addition of locations in the `socket_type` list. > > Little precision: this means current PR may never be merged. Fact is...

feat(socket): add several socket from item

@stonebuzz, I have tested this PR and I have the same result regarding the missing "name" of the socket as @KongNan As I saw, you changed the `socket_form.php`, but now...

feat(socket): add several socket from item

@stonebuzz, an addition: It would be great to have the possibility to add multiple sockets when opening the "add" form via `Cables` -> `Sockets`. It is just another way, but...

feat(socket): add several socket from item

@trasher as I can see, there is a pending review. May I ask you to take a look?

feat(socket): add several socket from item

@cedric-anne I am not sure, but @stonebuzz has completed your change requests, right? Could you take a look pleased? It would be nice, if these PRs can be merged soon

feat(socket): add several socket from item

@KongNan > > 1, When I use the from and to of the socket in reverse order (from 4 to 1), no content is added, which can be considered normal....

feat(socket): add several socket from item

> Hi @KongNan can you do a functional review of current PR? > > Best regards Hi @stonebuzz, I have done a functional review as well. Here is my checklist:...