Awesome-JSON-Viewer icon indicating copy to clipboard operation
Awesome-JSON-Viewer copied to clipboard
verified publisher icon rbrahul

Close menu on click

Open isopropylcyanide opened this issue 7 years ago • 5 comments

This PR does the following:

  1. Closes the copy popup on click which is more intuitive than hovering outside.
  2. Refactor code to remove JSX warnings (=== in place of ==, not following JSX conventions, spaces etc)

isopropylcyanide avatar Jan 13 '19 19:01 isopropylcyanide

Hi, can we merge this?

isopropylcyanide avatar Sep 30 '19 06:09 isopropylcyanide

Hi @isopropylcyanide Nowadays I became very busy with my personal job. I couldn't manage the time to test the behavior you implemented. Have you tested locally? If everything works as expected I can merge.

rbrahul avatar Oct 08 '19 14:10 rbrahul

Hi @isopropylcyanide Nowadays I became very busy with my personal job. I couldn't manage the time to test the behavior you implemented. Have you tested locally? If everything works as expected I can merge.

Yes, everything works as expected :) Thank you for the merge

isopropylcyanide avatar Oct 09 '19 06:10 isopropylcyanide

@rbrahul Resolved merge conflicts. Can we merge this?

isopropylcyanide avatar May 23 '20 11:05 isopropylcyanide

Bump @rbrahul

isopropylcyanide avatar Jul 13 '20 09:07 isopropylcyanide