Rob Bradford

Please setup the git hooks as described in the CONTRIBUTING.md file.

I think this is lgtm - @likebreath ?

> Because this code can block for upto 10s it can't be in the vmm thread. So you will need to create a new thread to run the code from...

@praveen-pk Do you want me to hold the release to integrate the feedback from @likebreath ?

@praveen-pk Just a couple of nits left from @likebreath's review. Could you address those and then we can merge this.

@retrage Are you only testing with CH or do you also have some QEMU support for aarch64?

This is the output I get when running with `main`: ``` root@ci-cloud-hypervisor-arm64-02:~/testing.rbradford/cloud-hypervisor# target/debug/cloud-hypervisor --serial tty --console off --kernel ~/testing.rbradford/rust-hypervisor-firmware/target/aarch64-unknown-none/release/hypervisor-fw --disk path=../jammy-server-cloudimg-arm64.raw --disk path=/tmp/ubuntu-cloudinit.img Booting with FDT Found PCI device vendor=8086...

The PCI device enumeration looks really wrong: This is what I get for RV64 on QEMU (which will be using the same MMIO ECAM code.) ``` Starting on RV64 0x0...

#233 fixes the erroneous bus reporting: ``` root@ci-cloud-hypervisor-arm64-02:~/testing.rbradford/cloud-hypervisor# target/debug/cloud-hypervisor --serial tty --console off --kernel ~/testing.rbradford/rust-hypervisor-firmware/target/aarch64-unknown-none/release/hypervisor-fw --disk path=../jammy-server-cloudimg-arm64.raw --disk path=/tmp/ubuntu-cloudinit.img Booting with FDT Found PCI device vendor=8086 device=d57 in slot=0 Found...

Are you implementing this only on KVM?