spinhawk icon indicating copy to clipboard operation
spinhawk copied to clipboard

hscmisc.c:1218:29: warning: duplicated 'if' condition [-Wduplicated-cond]

Open dcb314 opened this issue 6 years ago • 0 comments

Source code is

   if (inst[1] >= 0x29 && inst[1] <= 0x2C)
        addr2 = regs->GR(b2) & ADDRESS_MAXWRAP_E(regs);
    else
    if (inst[1] >= 0x29 && inst[1] <= 0x2C)
        addr2 = regs->GR(b2) & ADDRESS_MAXWRAP(regs);

Second if cannot be executed. Suggest code rework.

dcb314 avatar Jan 30 '19 16:01 dcb314