Richard Bonichon

Results 29 issues of Richard Bonichon

This is a disparate collection of minor fixes to the codebase: - add an explicit `of_int_exn` in module `Nat` (and propagate the change) - remove warning 16 in module Transition_frontier...

This PR adds minimal interfaces to *all* the modules of the library. This allows to clearly see the exported API a little bit more clearly in order to start documenting...

refactor
cleanup
ci-build-me

- activate warnings (and fix them) - move interface definitions in `Intf` only (and thus avoid repetition) - add interfaces to all modules - remove some dead code (thanks to...

code quality

CI has been reportedly very slow (up to a minute, under load) on some tests related to [this line](https://github.com/MinaProtocol/mina/blob/342018b083bf7c89186bbedf3bd949025243e266/src/lib/merkle_ledger/util.ml#L131). - [ ] reproduce issue - [ ] understand and fix...

Instead of deserializing the entire data, it should be sometimes more efficient to just look at particular subfields, e.g., when iterating over encoded data to access only a known sub-element....

code quality

Expose folding functions for Rocksdb (related to #1191)

1. Add proper interfaces (`mli` files) to the Rocksdb wrapper library. 2. Re-enable warnings 3. Update code

code quality

This PR removes the deprecation warning yielded by the use of `Caml.Stream` by depending on package `camlp-streams`.

Fix #14669. The initial coverage for the branch is: | % | Lines covered | File | --- | --- |--- | 35.83 | 67/187 | `src/lib/merkle_mask/maskable_merkle_tree.ml` | 51.55 |...

tests
code-coverage
berkeley-nice-to-haves

In reaction to the warning below , this PR removes docstring in implementation files. In addition, some are moved to the interface files, where I think they clearly belong ```...

code quality