identicon icon indicating copy to clipboard operation
identicon copied to clipboard

Still around?

Open ghost opened this issue 9 years ago • 4 comments

Howdy :wave:

I'm looking to maybe build upon your initial work with this library. I wasn't planning on anything major, just another implementation or two that is a little more expressive than the 5x5. I'm working fulltime on my www.ibgib.com app (github repo), and not to get too gory with details, I have a gib field that is a sha256 hash 99% of the time. So I definitely would like a friendly identicon for that :hash:.

I've already done an initial refactoring, but I wasn't going to create a PR until I've created the actual implementation. I wanted to ping you to see if you are interested in continuing this (and that PR), or if you're busy I can just create a new repo which credits back to you. Thanks! :+1: :smile:

ghost avatar Nov 07 '16 21:11 ghost

Sorry I missed this. Yes this is still around. I did a 5x5 because that was all I needed but I'm more than happy to accept PRs to extend the functionality.

rbishop avatar Apr 12 '17 16:04 rbishop

Ah, cool beans. I've just taken a quick look again at the code. I'm working on adjusting the Grid code (after a bit of a refactor) so that it will dynamically grow depending on any given size.

From what I've figured out, the code is fixed at the 15 bytes from the md5 hash because that is the 3 x 5 codes needed. I'm just tweaking it now to do this for any size. It's all backwards compatible, thanks to your foresight on the deterministic unit test.

After this, I'll see about doing something circular, as my ibGib code base deals largely with circular SVGs in d3.js. I considered a client-side identicon library, but you've responded first (:laughing:)! So we'll see what happens.

ghost avatar Apr 13 '17 00:04 ghost

In the above PR, you can see the output of the dynamic sizes in the fixtures folder where you have the existing 5x5 identicon for deterministic testing.

ghost avatar Apr 13 '17 16:04 ghost

Ah, I'll go ahead and post the 10x10 example:

elixir10

ghost avatar Apr 13 '17 16:04 ghost