doctoshotgun icon indicating copy to clipboard operation
doctoshotgun copied to clipboard

Add option to add specific center or doctor

Open Dreiundzwanzig opened this issue 3 years ago • 2 comments

Add options to:

  • add specific centers or doctors

Closes #68, closes #82

Dreiundzwanzig avatar Jun 20 '21 09:06 Dreiundzwanzig

Hello,

Thank you for your patch. However, I think it is not user friendly to ask user providing the name and city, as the url is enough to guess them. In my opinion, the code may be a little refactored to not apply args filters (--center, --center-regex, etc.) on ones provided with --aditional-center.

Another question related to the usecase itself, do you really want to add these centers to the search results, or are you targeting specifically these centers? Perhaps instead of --additional-center, it would be --center-url and in this case, do not do any search at all?

rbignon avatar Jul 18 '21 13:07 rbignon

Hello,

i've added them to the search result, because at the time of writing the code i didn't want to introduce as as little as possible merge conflicts, but thats not neccesary anymore if it ever was.

My personal usecase was to add additional centers/doctors from which i knew there offering vaccinations, but are not included in the search results and i wanted them to be processed additionally to the search results.

You are right, i've refactored the code and removed requirement for name and city.

Dreiundzwanzig avatar Jul 18 '21 17:07 Dreiundzwanzig