redisstore icon indicating copy to clipboard operation
redisstore copied to clipboard

max age 0

Open mergenchik opened this issue 4 years ago • 2 comments

There is a problem in implementation of func (s *RedisStore) Save for corner case of session.Options.MaxAge = 0. Expected behavior for cookie's MaxAge = 0 is to expire cookie when all tabs are closed. For redis, it is never expire. By putting MaxAge = 0, no cookie nor redis records are stored.

mergenchik avatar Jul 19 '20 19:07 mergenchik

See https://github.com/boj/redistore/commit/715bb322255772642fde27cc4a31e1d0089086c5#commitcomment-31303439

razorness avatar Jan 27 '21 10:01 razorness

I know this is an old one, but just to be clear: If I am using MaxAge = 0 this whole package can not be used at all? I mean yeah I can fork it and make my change there but...? Gorilla sessions are pretty clear when it comes to MaxAge.

mrccnt avatar Oct 16 '23 21:10 mrccnt