python-semanticversion icon indicating copy to clipboard operation
python-semanticversion copied to clipboard

ValueError after updating to 2.7

Open jaraco opened this issue 6 years ago • 6 comments

In pypa/twine#492, I discovered an issue where the doc builds started failing following the release of semantic-version 2.7. Pinning to <2.7 works around the issue. It's not obvious from the error message what the input is that's violating the expectation or what the correct fix might be. Twine's doc builds doesn't use semantic-version directly but instead relies on releases.

jaraco avatar Sep 07 '19 19:09 jaraco

Can you try with semantic-version 2.8.2? There were a couple of regressions in 2.7.0, fixed in the 2.8 series.

rbarrois avatar Sep 07 '19 19:09 rbarrois

OK, looking at the source of releases, the issue is there; I'll send a PR.

rbarrois avatar Sep 07 '19 19:09 rbarrois

Well, actually, releases is using python-semanticversion in very creative ways, playing with things that were supposed to be private-ish APIs; a fix might be complex.

@jaraco do you want to open an issue there, so they can take a look?

rbarrois avatar Sep 07 '19 20:09 rbarrois

I’m not sure when I’ll get to it. If you don't mind filling the issue, I expect your context about the issue would be more valuable than mine. If you don’t get to it, I likely will at some point. Thanks for the investigation.

jaraco avatar Sep 07 '19 20:09 jaraco

@jaraco: bugfix available on releases, now waiting for review ;) See https://github.com/bitprophet/releases/pull/86 for details.

rbarrois avatar Sep 07 '19 22:09 rbarrois

Thank you.

jaraco avatar Sep 08 '19 06:09 jaraco