Raphaël Balet

Results 180 comments of Raphaël Balet

@Galileon-venta We had to change the way the services work to be able to implement proper lazy loading. It should now fits your need. - Code example : https://github.com/ngx-translate/core/blob/develop/projects/test-app/src/app/pages/extended/extended.component.ts You...

A little update. I've started pocking around to implement this fix and could already do [the following PR](https://github.com/ngx-translate/core/pull/1545) I was ready to remove the `any` from the `Translation` type, but...

@CodeAndWeb Be careful, this is not only the test, but also when we're using it in our own project. It isn't able to detect the type because the type can...

@Ghostbird what I ment with that is 1. Can we take in account that the `.instant()` method is **always** returning a string? 2. If yes: they we change the type...

@CodeAndWeb now that I think about it. It's could actually be doable with type generic. But I'll make a proposition in that direction :)

@Ghostbird Sorry for the delay, we needed to take care of other matter beforehand. I couldn't figure out any solution to go without the `any` while not breaking the app...

> I'm not sure why this would break things for other people. The result should _never_ be `any`, right? It should be `string | Translation[] | TranslationObject`. The current union...

@Ghostbird Thanks for the openness behind this discussion. I'm agreeing with everything you say, but therefore will keep the issue open as it underlines a problem with the actual architecture....

@netoctone Yes, that seems correct and it was what we where thinking about. We've started other, more important topic though, so this will have to wait, or if anybody is...