csharp-language-server icon indicating copy to clipboard operation
csharp-language-server copied to clipboard

Sugestion/Request: Signature of symbol in documentSymbol

Open joefbkohler opened this issue 3 years ago • 9 comments

Workspace Symbol works perfectly by showing the signature, but Document Symbol doesn't. It can be confusing because of methods overloads, so it would be nice if the Name of the symbol included the signature.

joefbkohler avatar Aug 15 '22 23:08 joefbkohler

should be fixed as of https://github.com/razzmatazz/csharp-language-server/commit/b2c920cd41406474ea25d2852ea0014bfd22501f

will release a new version some time later

razzmatazz avatar Aug 18 '22 10:08 razzmatazz

https://www.nuget.org/packages/csharp-ls/0.5.4 has been released that should fix the issue

razzmatazz avatar Aug 20 '22 18:08 razzmatazz

It did :) but it seems to have a character limit that crops long namespaces/methods/signatures.

joefbkohler avatar Aug 26 '22 20:08 joefbkohler

mhm.. you mean on emacs?

it does it for me too, I think this is autocompletion framework (are you using ivy too?) restriction :/

because I see the full type going on the wire, will need to investigate, lets see if there are any tunables..

razzmatazz avatar Aug 30 '22 05:08 razzmatazz

or it could be lsp-mode.. as I can't see any tunables for ivy that restrict the length of the item at first glance

razzmatazz avatar Aug 30 '22 05:08 razzmatazz

Yeah, I'm using Ivy. But it works with long signatures in Workspce Symbol, References, etc...

joefbkohler avatar Aug 30 '22 13:08 joefbkohler

same thing for me.. I probably need to investigate what it is that truncates the text, deeper in lsp-mode

razzmatazz avatar Sep 05 '22 09:09 razzmatazz

It did :) but it seems to have a character limit that crops long namespaces/methods/signatures.

found the problem, at least on my emacs configuration imenu-max-item-length is set to 60; now I set it to 200 and things look ok for now:

(setq imenu-max-item-length 200)

at one point I was thinking about adding a function to lsp-ivy.el, but maybe not now:

  • https://github.com/emacs-lsp/lsp-ivy/issues/23

razzmatazz avatar Sep 13 '22 19:09 razzmatazz

btw, I am still working on documentSymbol to expose more information on items and hierarchical structure

razzmatazz avatar Sep 13 '22 19:09 razzmatazz