csharp-language-server icon indicating copy to clipboard operation
csharp-language-server copied to clipboard

Accepting action causes error

Open kstatz12 opened this issue 1 year ago • 3 comments

Args out of range: #<marker (moves after insertion) at 3252 in BranchSyncService.cs>, #<marker (moves after insertion) at 3252 in BranchSyncService.cs>

This happens occasionally in emacs 29 using lsp-mode. This might be a regression caused by https://github.com/razzmatazz/csharp-language-server/pull/116

kstatz12 avatar May 18 '24 22:05 kstatz12

I think this could rather be something about ignoring VersionedTextDocumentIdentifier.Version in csharp-ls. I could not not bother myself to understand and implement logic required for this. ...Or it could be something else

razzmatazz avatar May 20 '24 05:05 razzmatazz

I added https://github.com/razzmatazz/csharp-language-server/commit/2bdcec738aa2afec1656ddc6d0a57b9a1deae50a to help trace doubly-finished requests which shouldn't ever happen

razzmatazz avatar May 20 '24 05:05 razzmatazz

I think this could rather be something about ignoring VersionedTextDocumentIdentifier.Version in csharp-ls. I could not not bother myself to understand and implement logic required for this. ...Or it could be something else

this stinks of a lamport clock of some kind

kstatz12 avatar May 21 '24 22:05 kstatz12