csharp-language-server icon indicating copy to clipboard operation
csharp-language-server copied to clipboard
verified publisher icon razzmatazz

Refactor the architecture (rebased)

Open razzmatazz opened this issue 1 year ago • 3 comments

Loosly-rebased (does not compile) version of https://github.com/razzmatazz/csharp-language-server/pull/102 by @tcx4c70 so I can begin cherry-picking things back to master

razzmatazz avatar Feb 03 '24 15:02 razzmatazz

Hi, @razzmatazz , I have done some rebase on my branch https://github.com/tcx4c70/csharp-language-server/tree/rework, maybe it can make the cherry-pick easier. And I'm still investigating the crash on arm64, so please don't cherry-pick commit "feat: Prevent MSBuildWorkspace.TryApplyChanges from saving changes to disk" for now.

tcx4c70 avatar Feb 04 '24 02:02 tcx4c70

Hi, @razzmatazz , I have done some rebase on my branch https://github.com/tcx4c70/csharp-language-server/tree/rework, maybe it can make the cherry-pick easier. And I'm still investigating the crash on arm64, so please don't cherry-pick commit "feat: Prevent MSBuildWorkspace.TryApplyChanges from saving changes to disk" for now.

Thank you!

razzmatazz avatar Feb 12 '24 07:02 razzmatazz

@tcx4c70 at some point I will ask you help to extract some of the changes as separate PRs,–that is once I get the bits-im-sure-about merged in. As I am afraid the state of the "rework" tree and commits will not make sense when I finish checking the changes.

razzmatazz avatar Feb 12 '24 07:02 razzmatazz