puppet-network icon indicating copy to clipboard operation
puppet-network copied to clipboard

Substantial refactor

Open ghoneycutt opened this issue 11 years ago • 5 comments

Lots of style fixes to pass puppet-lint and created parameterized classes which allow for data to specified with Hiera in Puppetv3.

ghoneycutt avatar May 23 '13 08:05 ghoneycutt

@ghoneycutt : You may want to rebase onto the develop branch. I am about to release a version 3.0.0.

razorsedge avatar May 27 '13 00:05 razorsedge

+1 to this one!!

naevtamarkus avatar Jun 11 '14 14:06 naevtamarkus

Would love to have the functionality of configuration the network module using hiera which this pull request includes. Would it be possible to push this pull request further @razorsedge and @ghoneycutt? Otherwise should a separate pull request be created with this functionality?

anders-larsson avatar Jul 29 '15 10:07 anders-larsson

@anders-larsson you have this compatibility :)

Your Puppetfile should have my repo and this branch

ghoneycutt avatar Jul 29 '15 15:07 ghoneycutt

True enough :)

Would be nice to use the upstream version though since it has received a lot of new features and are actively developed. Just thought it would be nice if hiera support could be merged into the upstream module. More features for everyone. Thank you for responding.

anders-larsson avatar Jul 29 '15 18:07 anders-larsson