vue3-calendar-heatmap icon indicating copy to clipboard operation
vue3-calendar-heatmap copied to clipboard

Set first day of week

Open fritz-net opened this issue 1 year ago • 3 comments

Since in most parts of the world the week does not start with sunday I implemented this.

fritz-net avatar Jan 04 '24 13:01 fritz-net

This pull request also includes the pull request for Support more than 5 colors. Also it adds the package-lock.json file, which isn't included in the repository currently. (I don't know if this is intended or not, I'm neither the maintainer, nor do I use this package actively myself.)

But appart from these, I'd love to see this merged.

SteffoSpieler avatar Feb 25 '24 14:02 SteffoSpieler

@SteffoSpieler thanks for the review. The other PR is included since I forked for this feature from my main and not the one in the original, totally missed that.

I would create a different branch and cherry pic the related changes if the Maintainer is willing to merge it in the first place. ( cherry picking resulted in merge conflicts since I changed the constructor in both PRs I think)

fritz-net avatar Mar 08 '24 16:03 fritz-net

as far as I found out package-lock.json should be checked in: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

fritz-net avatar Mar 08 '24 16:03 fritz-net