redis-openshift-example icon indicating copy to clipboard operation
redis-openshift-example copied to clipboard

Build script needs update due to change in openshift environment variables

Open rw950431 opened this issue 12 years ago • 3 comments

Openshift have deleted the trailing / off all of their enviroment variables.

Hence lines in .openshift/action_hooks/build like ${OPENSHIFT_RUN_DIR}redis.pid need to change to ${OPENSHIFT_RUN_DIR}/redis.pid

It would be nice to bump redis version to latest also..

rw950431 avatar Nov 12 '12 05:11 rw950431

Openshift team changed back these environments. echo ${OPENSHIFT_RUN_DIR}/redis.pid /var/lib/openshift/......./ruby-1.9/run//redis.pid

echo ${OPENSHIFT_RUN_DIR}redis.pid /var/lib/openshift/......./ruby-1.9/run/redis.pid

quatermain avatar Nov 12 '12 11:11 quatermain

You're absolutely right! Doh!

Wish they would make up their mind...
Fortunately most scripts seem to tolerate the '//'

rw950431 avatar Nov 12 '12 22:11 rw950431

@rw950431 thanks for your feedback :+1: I hence left a bit the development of this because the openshift guys took it in their account, but absolutely i'm gonna update the new version.

And yeah the consequent // is the same as / in shell scripting :)

razorinc avatar Nov 12 '12 23:11 razorinc