emitron-Android icon indicating copy to clipboard operation
emitron-Android copied to clipboard

Published 20 hours ago • verified publisher icon razeware

Update Room to Support M1 Macbooks

Open jumaallan opened this issue 2 years ago • 6 comments

Fixes Room Issue #340 when running the project on an M1 Mac

Some notes:

This might need to ship as is, since updating to the latest Room version means we need to target sdk 31. This introduces more changes which are out of scope for this PR

jumaallan avatar May 18 '22 08:05 jumaallan

@wangerekaharun could you take a look at this PR please, once you've got the updates you've been working on integrated? Thanks!

sammyd avatar May 24 '22 07:05 sammyd

@wangerekaharun could you take a look at this PR please, once you've got the updates you've been working on integrated? Thanks!

@sammyd this can be merged, so that I can pull the changes.

wangerekaharun avatar May 24 '22 07:05 wangerekaharun

@jumaallan thanks so much for this. Sadly, I've just merged a pretty big PR to address a login issue to development, and there are now some conflicts. Would you be able to resolve these conflicts and ask for another review please? Thanks!

sammyd avatar May 27 '22 10:05 sammyd

@sammyd I have fixed the small conflicts. Should be ready for review again

jumaallan avatar May 27 '22 10:05 jumaallan

@sammyd / @wangerekaharun Ping

The CI failure is related to keystore config missing. You can take a look at this @wangerekaharun

jumaallan avatar Jun 03 '22 15:06 jumaallan

I'll look into this @jumaallan also you can pull the development branch since I raised a PR and CI was not failing.

wangerekaharun avatar Jun 03 '22 18:06 wangerekaharun