SmartThings-BigTalker-Orig icon indicating copy to clipboard operation
SmartThings-BigTalker-Orig copied to clipboard

Published 20 hours ago • verified publisher icon rayzurbock

Configure Defaults: Volume, Do Not Talk times required

Open rayzurbock opened this issue 9 years ago • 3 comments

The "optional" Volume, "Do not talk before", and "Do not talk after" settings on the Configure Defaults page seem to be required.

Reported 2/1/2016 by STCommunity:gcortes

rayzurbock avatar Feb 02 '16 00:02 rayzurbock

I believe this is going to be found in BigTalker 1.1.5 on line 1660. I don't think the expression required: (!(settings.defaultStartTime == null)) is being evaluated as I expected in this line: input "defaultEndTime", "time", title: "Don't talk after: ", required: (!(settings.defaultStartTime == null)), submitOnChange: true

Will likely need to change to: required: ((settings.defaultStartTime != null && settings.defaultStartTime != "") ? true : false)

rayzurbock avatar Mar 19 '16 00:03 rayzurbock

Also, I believe line 3218 needs to be addressed. if (settings.defaultStartTime == null) {

should probably be changed to: if ((settings.defaultStartTime != null && settings.defaultStartTime != "") ? false : true) {

rayzurbock avatar Mar 19 '16 00:03 rayzurbock

Beta version posted here: https://github.com/rayzurbock/SmartThings-BigTalker/tree/1.1.6-Beta Please test and let me know if you find this issue now resolved.

rayzurbock avatar Mar 19 '16 01:03 rayzurbock