Ray Terrill
Ray Terrill
I'm sorry @AndreZiviani I'm still not understanding. When I grab atlantis@master, and then compare it to my PR, the results appear identical to me, which is what I was going...
@lilincmu Let me test that out - that's definitely a scenario we're using, and I can pretty easily test that out in our environment using a build of this PR....
@lilincmu Added a new GetPullReviewDecision function which calls the graphql api - this indeed takes into account CODEOWENRS and correctly returns "REVIEW_REQUIRED" when a CODEOWNER has not approved the request...
@jamengual it doesnt look like atlantis passes userConfig down to NewGithubClient. I could definitely add that in, might be worth adding in the entire userConfig to allow additional flags to...
It's a good question. I'm a 1st time contributor and thus looking for guidance from more seasoned contribs. No issue with feature flag rollout to minimize disruptions/accidentally introducing something else...
Tracking another issue - looks like a previous PR attempt ran into issues with Github Actions-based checks. I added one to a test PR, and indeed, the CombinedStatus API doesn't...
@lilincmu might it make more sense to build a new "GithubConfig" struct, and pass that into NewGithubClient? That would give a sustainable, go-forward way to influence github-specific behavior in the...
- Added feature flag protection for the new functionality with a new GithubConfig struct and CLI flags - default false - Added check against the check suites API to handle...
I did think an issue this wknd that I'm testing for now - I don't think the checks api has any indication about required checks vs not - looks like...
Added additional logic to suss out only the required check runs and ignore non-required, added server config doc.