raccoon icon indicating copy to clipboard operation
raccoon copied to clipboard

fix: panic for unknown topic metric

Open 321pranay opened this issue 10 months ago • 0 comments

This PR fixes panic when multiple requests are made for a topic which does not exist

ERRO[2024-04-09T16:39:44+05:30] [worker] Fail to publish message to kafka Broker: Unknown topic or partition 
DEBU[2024-04-09T16:39:44+05:30] Success sending messages, 0                  
panic: inconsistent label cardinality: expected 2 label values but got 3 in prometheus.Labels{"conn_group":"--default--", "event_type":"abc", "topic":"log.telemetry.abc"}

goroutine 43 [running]:
github.com/prometheus/client_golang/prometheus.(*CounterVec).With(0x100ff6a00?, 0x1400020ce70?)
        /Users/rapido/go/pkg/mod/github.com/prometheus/[email protected]/prometheus/counter.go:286 +0x80
github.com/raystack/raccoon/metrics.(*PrometheusCollector).Increment(0x110?, {0x100d9f85c, 0x21}, 0x101086ee0?)
        /Users/rapido/work/raccoon-2/metrics/prometheus.go:77 +0x64
github.com/raystack/raccoon/metrics.Increment({0x100d9f85c?, 0x140000f2450?}, 0x100d8d0ff?)
        /Users/rapido/work/raccoon-2/metrics/metrics.go:45 +0x4c
github.com/raystack/raccoon/publisher.(*Kafka).ProduceBulk(0x14000286000, {0x1400029a140, 0x1, 0x6?}, {0x100d8d61a, 0xb}, 0x1?)
        /Users/rapido/work/raccoon-2/publisher/kafka.go:66 +0x518
github.com/raystack/raccoon/worker.(*Pool).StartWorkers.func1({0x14000204090, 0x8})
        /Users/rapido/work/raccoon-2/worker/worker.go:47 +0x214
created by github.com/raystack/raccoon/worker.(*Pool).StartWorkers
        /Users/rapido/work/raccoon-2/worker/worker.go:39 +0x3c
exit status 2

321pranay avatar Apr 09 '24 11:04 321pranay