optimus icon indicating copy to clipboard operation
optimus copied to clipboard

Published 20 hours ago • verified publisher icon raystack

feat: Job Inspect

Open Mryashbhardwaj opened this issue 2 years ago • 1 comments

fixes : #494 #492 #493

Mryashbhardwaj avatar Aug 29 '22 05:08 Mryashbhardwaj

Pull Request Test Coverage Report for Build 3295386652

  • 77 of 106 (72.64%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 80.565%
Changes Missing Coverage Covered Lines Changed/Added Lines %
models/job.go 0 3 0.0%
api/handler/v1beta1/job_spec.go 16 25 64.0%
job/service.go 48 65 73.85%
<!-- Total: 77 106
Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
<!-- Total: 2
Totals Coverage Status
Change from base Build 3287481486: -0.1%
Covered Lines: 7905
Relevant Lines: 9812
💛 - Coveralls

coveralls avatar Aug 29 '22 05:08 coveralls

LGTM. If possible you can add more test cases before merging.

how about adding more tests after the final refactor

Mryashbhardwaj avatar Oct 18 '22 01:10 Mryashbhardwaj