optimus
optimus copied to clipboard
Published
20 hours ago •
raystack
raystack
feat: get compiled job assets from JobRunInput api
proton PR:: https://github.com/odpf/proton/pull/155
Future plans : https://github.com/odpf/optimus/issues/443
Pull Request Test Coverage Report for Build 2838115849
- 76 of 105 (72.38%) changed or added relevant lines in 7 files are covered.
- 2 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.1%) to 75.816%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| compiler/job_asset_compiler.go | 22 | 23 | 95.65% |
| compiler/job_input_render.go | 0 | 1 | 0.0% |
| compiler/job_run_input_compiler.go | 13 | 14 | 92.86% |
| service/monitoring_service.go | 5 | 10 | 50.0% |
| api/handler/v1beta1/job_run.go | 33 | 54 | 61.11% |
| <!-- | Total: | 76 | 105 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| job/external_dependency_resolver.go | 1 | 79.75% |
| service/monitoring_service.go | 1 | 74.36% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 2823967747: | -0.1% |
| Covered Lines: | 7408 |
| Relevant Lines: | 9771 |
💛 - Coveralls
I think it is better to create another PR for deprecating the old admin build instance command and the corresponding api
