Getting 3 times slack notification for same resource reminder

[singhvikash11]

Description For the same resource expiration guardian send 3 times notification, I am guessing the reordering of var notifications can cause issues.

[bsushmith]

This is a misconfiguration issue from the deployment side due to multiple configurations that need to be set to disable one job -

In code, JobConfig.Enabled is set to true by default (for backward compatibility)

and while checking for jobs that need to be enabled in the server, we check for both access and grants jobs enabled for backward compatibility.

This would necessitate disabling both if we want to run these jobs outside server as part of deployment.

JOBS:
  FETCH_RESOURCES:
    Enabled: false
    Interval: "*/1 * * * *"
  REVOKE_EXPIRED_ACCESS:
    Enabled: false
    Interval: "*/1 * * * *"
  REVOKE_EXPIRED_GRANTS:
    Enabled: false
  EXPIRING_ACCESS_NOTIFICATION:
    Enabled: false
    Interval: "*/1 * * * *"
  EXPIRING_GRANT_NOTIFICATION:
    Enabled: false

We should consider if we can deprecate these backward compatibilities and have only one config moving forward and have JobConfig.Enabled set to false by default.

@rahmatrhd @haveiss @mabdh @utsav-agarwal

[mabdh]

@singhvikash11 I would suggest to redact some sensitive data from the screenshot, e.g. url, bq project name