guardian icon indicating copy to clipboard operation
guardian copied to clipboard

Approver still see appeal after they got removed from the approver list

Open rahmatrhd opened this issue 2 years ago • 0 comments

Description After removing an approver from an appeal, they still see that appeal in their approvals list (GetUserApprovals)

To Reproduce

  1. Remove an approver from an appeal
  2. Ask the removed approver to access GetUserApprovals or GET /me/approvals
  3. They will still see the same appeal listed in the response

Proposed Solution This happens because of soft deletion. Need to update the query to add condition: WHERE deleted_at IS NULL in list approvals API

rahmatrhd avatar Sep 02 '22 03:09 rahmatrhd