guardian icon indicating copy to clipboard operation
guardian copied to clipboard

Published 20 hours ago • verified publisher icon raystack

feat: add db connection configuration

Open singhvikash11 opened this issue 2 years ago • 1 comments

Address connection setting

singhvikash11 avatar Aug 11 '22 07:08 singhvikash11

Pull Request Test Coverage Report for Build 2838249550

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 75.961%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/store.go 0 9 0.0%
<!-- Total: 0 9
Files with Coverage Reduction New Missed Lines %
internal/store/postgres/store.go 1 0%
<!-- Total: 1
Totals Coverage Status
Change from base Build 2831363521: -0.09%
Covered Lines: 5574
Relevant Lines: 7338
💛 - Coveralls

coveralls avatar Aug 11 '22 07:08 coveralls

@singhvikash11 these changes are present in the latest version of salt. Can we bump up the salt version and use that?

bsushmith avatar Aug 31 '22 16:08 bsushmith

@singhvikash11 +1, we plan to remove Gorm. So salt/db package will be used for this. If any of the missing setting is not there then lets raise PR for that in salt.

ravisuhag avatar Sep 21 '22 18:09 ravisuhag