compass icon indicating copy to clipboard operation
compass copied to clipboard

support pagination in search assets rpc

Open bsushmith opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. support pagination in SearchAssets rpc.

bsushmith avatar Feb 13 '23 10:02 bsushmith

@bsushmith why do we need pagination in searchAssets? We should only have limit based on number of search results on?

https://github.com/odpf/compass/issues/196

ravisuhag avatar Feb 16 '23 08:02 ravisuhag

Currently we are revamping our UI, and we would like to use this API and show only a few results in search and let user navigate pages if needed based on the ranking strategy that is employed rather than show 100 or 200 which is the default MaxSize.

bsushmith avatar Feb 16 '23 09:02 bsushmith

Would it make sense to use list API in that case?

ravisuhag avatar Feb 16 '23 14:02 ravisuhag