compass
compass copied to clipboard
refactor: stop usage of deprecated fields in LineageNode
- Stop usage of v1beta1.LineageNode.{type, service}. The URN is now sufficient to uniquely identify the node.
- Modify interfaces and service to stop usage of core/asset.LineageNode, just use the URN.
- core/asset.Service struct.
- core/asset/LineageRepository interface.
- Remove the type core/asset.LineageEdge.
BREAKING CHANGES:
- Types modified - core/asset.Service, core/asset/LineageRepository.
- Type removed - core/asset.LineageEdge.
Pull Request Test Coverage Report for Build 3334483510
- 35 of 35 (100.0%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.03%) to 86.085%
| Totals | |
|---|---|
| Change from base Build 3334473100: | -0.03% |
| Covered Lines: | 4875 |
| Relevant Lines: | 5663 |
💛 - Coveralls
Nice @sudo-suhas! Totally forgot that we now can do this
~~Also CMIIW, this will require changes. on meteor's compass sink right? @sudo-suhas~~
Edit: Just tested this and it works fine, it seems like we still keep the API contract and just changing the internal APIs 👌