Should the service or ingress annotations be part of the charts

[bsushmith]

Summary Should the service or ingress annotations be part of the charts, since the current values are based on our internal infra, and users can have their own different controllers?

Example:

• Service annotation

  service:
    annotations:
      projectcontour.io/upstream-protocol.h2c: tcp

https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml#L33

• Ingress annotation:

  ingress:
    enabled: true
    annotations:
      kubernetes.io/ingress.class: contour

https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml#L66

Related discussion - https://github.com/odpf/charts/pull/66#discussion_r940912752

[bsushmith]

@ravisuhag @rohilsurana @snorlacs WDYT?

[rohilsurana]

I support that we remove it from here and supply it as a config at time of deployment on our side.

[ravisuhag]

+1 to @rohilsurana