libv4l-rs
libv4l-rs copied to clipboard
raymanfx
basic multi-plane support
I care about creating a capture stream with a multi-plane camera. I have a basic version of it working, with inspiration from your mplane branch. What works:
- get/set/list formats
- create an mmap capture stream
- stream frames from it
I would like to see this merged into a release as I am also interested in using this on an imx8 system.
@raymanfx, @illegalprime, and @anatawa12 I have a project that uses a single plane, and a plan to add support for a multiple plane device. This PR only introduced only 1 breaking change (this project is still in 0 major, so that shouldn't be an issue) to my project, which is that Stream::next() gives a slice of slices instead of a slice. The type system will give the user information about what needs changing, and the Cargo.lock file will prevent the change from occurring for people who just want to make a working build of something, and don't want to fix anything to work with newer libs at the moment, so this PR can be merged as soon as https://github.com/illegalprime/libv4l-rs/pull/1 lands. Thanks!
Thank you for cleaning up the conflicts! Even though nobody's experience would necessarily break with this addition it should still not be merged until the author decides this is the abstraction they prefer.