CustomPermissionsDialogue
CustomPermissionsDialogue copied to clipboard
rayliverified
No method to include READ_PHONE_STATE
A substate of the Manifest.permission.CALL_PHONE but needed when you only need partial permissions to phone services.
Webpage not available
body { margin-top: 0px; padding-top: 0px; } /* Used for additional styles, e.g. direction */
h2 { margin-top: 5px; padding-top: 0px; }
Hi Kenneth,
Thanks for taking a look! If you submit a PR, I'll review and merge it.- Ray
It appears that the repository is locked; I cannot push the branch with the changes. Or it’s working differently than prior times.
I’ve attached the 2 changed files.
Note: I’m not handling the fact that CALL_PHONE includes READ_PHONE_STATE. If users want to show descriptions for both or even show both permissions it would be a valid use-case. The code could be overly smart and remove READ_PHONE_STATE if there is no description and both CALL_PHONE and READ_PHONE_STATE but I figure this is more effort than it’s worth. If you disagree, let me know and I’ll add the additional logic.
Thanks,
Ken
From: Ray Li [mailto:[email protected]] Sent: Saturday, October 19, 2019 3:06 PM To: searchy2/CustomPermissionsDialogue [email protected] Cc: Kenneth A. Argo [email protected]; Author [email protected] Subject: Re: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6)
Webpage not available
body { margin-top: 0px; padding-top: 0px; } /* Used for additional styles, e.g. direction */ h2 { margin-top: 5px; padding-top: 0px; }
Hi Kenneth,
Thanks for taking a look! If you submit a PR, I'll review and merge it.- Ray
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/searchy2/CustomPermissionsDialogue/issues/6?email_source=notifications&email_token=ADHP4OGOV5Q6Q22GDPYAUW3QPOAEBA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5SWA#issuecomment-544201048 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHP4OBG4X24HVPCBUZ3FFTQPOAEBANCNFSM4JCRT6GA . https://github.com/notifications/beacon/ADHP4OEGWAHTJ2B5D7LP5CTQPOAEBA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5SWA.gif
Hi Ken,
You will need to create another branch by forking this repository before any changes can be made. Or, if you send me the modified files, I can make the changes. It looks like Github doesn't get the files that you attach through your email.
- Ray
Oh, ok, I'll do that today.
Get BlueMail for Android
On Oct 20, 2019, 10:31 AM, at 10:31 AM, Ray Li [email protected] wrote:
Hi Ken,
You will need to create another branch by forking this repository before any changes can be made. Or, if you send me the modified files, I can make the changes. It looks like Github doesn't get the files that you attach through your email.
- Ray
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/searchy2/CustomPermissionsDialogue/issues/6#issuecomment-544273341
I completed the push yesterday morning. Let me know what you think and if you take the changes so I can integrate the GIT version rather than my private.
Thanks,
Ken
From: Kenneth A. Argo [mailto:[email protected]] Sent: Saturday, October 19, 2019 5:05 PM To: 'searchy2/CustomPermissionsDialogue' [email protected]; 'searchy2/CustomPermissionsDialogue' [email protected] Cc: 'Author' [email protected] Subject: RE: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6)
It appears that the repository is locked; I cannot push the branch with the changes. Or it’s working differently than prior times.
I’ve attached the 2 changed files.
Note: I’m not handling the fact that CALL_PHONE includes READ_PHONE_STATE. If users want to show descriptions for both or even show both permissions it would be a valid use-case. The code could be overly smart and remove READ_PHONE_STATE if there is no description and both CALL_PHONE and READ_PHONE_STATE but I figure this is more effort than it’s worth. If you disagree, let me know and I’ll add the additional logic.
Thanks,
Ken
From: Ray Li [mailto:[email protected]] Sent: Saturday, October 19, 2019 3:06 PM To: searchy2/CustomPermissionsDialogue <[email protected] mailto:[email protected] > Cc: Kenneth A. Argo <[email protected] mailto:[email protected] >; Author <[email protected] mailto:[email protected] > Subject: Re: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6)
Webpage not available
body { margin-top: 0px; padding-top: 0px; } /* Used for additional styles, e.g. direction */ h2 { margin-top: 5px; padding-top: 0px; }
Hi Kenneth,
Thanks for taking a look! If you submit a PR, I'll review and merge it.- Ray
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/searchy2/CustomPermissionsDialogue/issues/6?email_source=notifications&email_token=ADHP4OGOV5Q6Q22GDPYAUW3QPOAEBA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5SWA#issuecomment-544201048 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHP4OBG4X24HVPCBUZ3FFTQPOAEBANCNFSM4JCRT6GA . https://github.com/notifications/beacon/ADHP4OEGWAHTJ2B5D7LP5CTQPOAEBA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5SWA.gif
Yea, but I missed a corner case when only READ_STATE (with no description) was indicated. I just pushed the fix.
From: Ray Li [mailto:[email protected]] Sent: Wednesday, October 23, 2019 12:34 PM To: searchy2/CustomPermissionsDialogue [email protected] Cc: Kenneth A. Argo [email protected]; Author [email protected] Subject: Re: [searchy2/CustomPermissionsDialogue] No method to include READ_PHONE_STATE (#6)
Hey Ken,
Just wanted to follow up. Is v2.2.0 working for you?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/searchy2/CustomPermissionsDialogue/issues/6?email_source=notifications&email_token=ADHP4OC6RFCBSEBOVJVUW4LQQCRKJA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCTSSY#issuecomment-545601867 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHP4OC674Y3SKPSOBI662TQQCRKJANCNFSM4JCRT6GA . https://github.com/notifications/beacon/ADHP4OGSJFRPNIJSOJDNZ3TQQCRKJA5CNFSM4JCRT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCTSSY.gif
I thought I replied but I don't see it.
I had to push a one line additional change to cover a corner case. The old code worked but I removed the description from code and then it stopped working.
When you get a chance, I sent a pull request.
Get BlueMail for Android
On Oct 23, 2019, 12:34 PM, at 12:34 PM, Ray Li [email protected] wrote:
Hey Ken,
Just wanted to follow up. Is v2.2.0 working for you?
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/searchy2/CustomPermissionsDialogue/issues/6#issuecomment-545601867