hibernate-memcached icon indicating copy to clipboard operation
hibernate-memcached copied to clipboard

Added support for synchronous writes

Open burtbeckwith opened this issue 12 years ago • 7 comments

I'm working with Luis Arias to make this available for the Grails plugin

burtbeckwith avatar Feb 29 '12 20:02 burtbeckwith

Sorry for the delay. I really don't want to pull in the massive cleanup commit (87d323c). It's a bit heavy handed, if there are specific things that should be fixed call those out.

Commit cd7ab28 is simple enough but it breaks the build. Please run "mvn test" and ensure all tests pass.

raykrueger avatar Mar 02 '12 19:03 raykrueger

I don't use Maven, but I ran all the tests except the Hibernate ones and everything worked. Is there a compile problem, or did particular tests fail? Could you email me the build output?

burtbeckwith avatar Mar 02 '12 20:03 burtbeckwith

There's a change in the cleanup commit that might be the culprit - in AbstractKeyStrategyTestCase I had to change shouldFailWithCause to shouldFail. I wasn't sure how the tests could have been passing before, but I didn't run them until after my changes. But I can't see how what I did could have affected that.

burtbeckwith avatar Mar 02 '12 20:03 burtbeckwith

I just ran mvn test after cherrypicking Commit cd87ab28 w/o any issues. My fork is up to date.

kaaloo avatar Mar 05 '12 17:03 kaaloo

You might want to get commit af12ed96e5 too since there was an issue with logging in the update.

kaaloo avatar Mar 05 '12 17:03 kaaloo

I found the problem with the tests failing on my side. If you run them with mvn test the mock log appender was left set as the only appender. That was then failing it's assertion during other tests.

I've merged cd7ab28 and fixed the Logger test and pushed to burtbeckwith-contrib. I'll wait for verification of the NullPointerException before proceeding.

raykrueger avatar Mar 05 '12 18:03 raykrueger

Thanks, I just pushed to that logger fix to burtbeckwith-contrib as well. https://github.com/raykrueger/hibernate-memcached/tree/burtbeckwith-contrib

raykrueger avatar Mar 05 '12 18:03 raykrueger